linux-kernel - Re: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202407140536.iIizeGVy-lkp@intel.com>
Date: Sun, 14 Jul 2024 05:11:14 +0800
From: kernel test robot <lkp@...el.com>
To: Keguang Zhang via B4 Relay <devnull+keguang.zhang.gmail.com@...nel.org>,
	Keguang Zhang <keguang.zhang@...il.com>,
	Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-mips@...r.kernel.org,
	dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB
 DMA driver

Hi Keguang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on d35b2284e966c0bef3e2182a5c5ea02177dd32e4]

url:    https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang-via-B4-Relay/dt-bindings-dma-Add-Loongson-1-APB-DMA/20240711-191657
base:   d35b2284e966c0bef3e2182a5c5ea02177dd32e4
patch link:    https://lore.kernel.org/r/20240711-loongson1-dma-v9-2-5ce8b5e85a56%40gmail.com
patch subject: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407140536.iIizeGVy-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:598,
                    from include/asm-generic/bug.h:22,
                    from arch/x86/include/asm/bug.h:87,
                    from include/linux/bug.h:5,
                    from include/linux/fortify-string.h:6,
                    from include/linux/string.h:374,
                    from include/linux/scatterlist.h:5,
                    from include/linux/dmapool.h:14,
                    from drivers/dma/loongson1-apb-dma.c:8:
   drivers/dma/loongson1-apb-dma.c: In function 'ls1x_dma_start':
>> drivers/dma/loongson1-apb-dma.c:137:34: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
     137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
     224 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
     273 |         _dynamic_func_call(fmt, __dynamic_dev_dbg,              \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:165:9: note: in expansion of macro 'dynamic_dev_dbg'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:165:30: note: in expansion of macro 'dev_fmt'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                              ^~~~~~~
   drivers/dma/loongson1-apb-dma.c:137:9: note: in expansion of macro 'dev_dbg'
     137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
         |         ^~~~~~~
   drivers/dma/loongson1-apb-dma.c:137:63: note: format string is defined here
     137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
         |                                                              ~^
         |                                                               |
         |                                                               unsigned int
         |                                                              %llx


vim +137 drivers/dma/loongson1-apb-dma.c

   130	
   131	static inline int ls1x_dma_start(struct ls1x_dma_chan *chan,
   132					 dma_addr_t *hwdesc_phys)
   133	{
   134		struct dma_chan *dchan = &chan->vchan.chan;
   135		int val, ret;
   136	
 > 137		dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
   138			dchan->cookie, *hwdesc_phys);
   139	
   140		val = *hwdesc_phys & DMA_ADDR_MASK;
   141		val |= DMA_START;
   142		val |= dchan->chan_id;
   143		chan_writel(chan, DMA_CTRL, val);
   144		ret = readl_poll_timeout(chan->reg_base + DMA_CTRL, val,
   145					 !(val & DMA_START), 0, 3000);
   146		if (ret)
   147			dev_err(chan2dev(dchan), "failed to start DMA\n");
   148	
   149		return ret;
   150	}
   151	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki