linux-kernel - Re: [PATCH] erofs: silence uninitialized variable warning in z_erofs_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91b66d05-eeff-4d84-a726-cee087bce967@linux.alibaba.com>
Date: Sat, 13 Jul 2024 12:44:04 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Gao Xiang <xiang@...nel.org>
Cc: Chao Yu <chao@...nel.org>, Yue Hu <huyue2@...lpad.com>,
 Jeffle Xu <jefflexu@...ux.alibaba.com>, Sandeep Dhavale
 <dhavale@...gle.com>, linux-erofs@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] erofs: silence uninitialized variable warning in
 z_erofs_scan_folio()



On 2024/7/13 09:04, Dan Carpenter wrote:
> Smatch complains that:
> 
>      fs/erofs/zdata.c:1047 z_erofs_scan_folio()
>      error: uninitialized symbol 'err'.
> 
> The issue is if we hit this (!(map->m_flags & EROFS_MAP_MAPPED)) {
> condition then "err" isn't set.  It's inside a loop so we would have to
> hit that condition on every iteration.  Initialize "err" to zero to
> solve this.
> 
> Fixes: 5b9654efb604 ("erofs: teach z_erofs_scan_folios() to handle multi-page folios")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks, applied.

Thanks,
Gao Xiang