linux-kernel - Re: [PATCH] eeprom: ee1004: Fix locking issues in ee1004

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5eda1109-5656-4a0d-9444-6a18bb1b382c@suswa.mountain>
Date: Sat, 13 Jul 2024 20:18:50 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Armin Wolf <W_Armin@....de>
Cc: arnd@...db.de, gregkh@...uxfoundation.org, hkallweit1@...il.com,
	linux@...ck-us.net, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, ukleinek@...nel.org
Subject: Re: [PATCH] eeprom: ee1004: Fix locking issues in ee1004_probe()

On Sun, Jul 14, 2024 at 01:48:13AM +0200, Armin Wolf wrote:
> Currently, the devres-based management of ee1004_bus_data has
> several issues when it comes to locking:
> 
> 1. It does not call mutex_unlock() before returning an error.
> 
> 2. When encountering an error, it deadlocks when trying to recursively
>    lock a mutex.
> 
> Fix this by moving the mutex-protected bus data initialization into
> a separate function so that devm_add_action_or_reset() is called
> without the mutex being held.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Fixes: 55d57ef6fa97 ("eeprom: ee1004: Use devres for bus data cleanup")
> Signed-off-by: Armin Wolf <W_Armin@....de>
> ---

Looks good.  :)

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter