linux-kernel - [PATCH] cifs: Use seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <18310e20-826f-45ab-b69e-dbfe47a1f83f@web.de>
Date: Sun, 14 Jul 2024 10:35:00 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: samba-technical@...ts.samba.org, linux-cifs@...r.kernel.org,
 kernel-janitors@...r.kernel.org, Bharath SM <bharathsm@...rosoft.com>,
 Paulo Alcantara <pc@...guebit.com>,
 Ronnie Sahlberg <ronniesahlberg@...il.com>,
 Shyam Prasad N <sprasad@...rosoft.com>, Steve French <sfrench@...ba.org>,
 Tom Talpey <tom@...pey.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] cifs: Use seq_putc() in two functions

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sun, 14 Jul 2024 10:23:49 +0200

Single characters should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/smb/client/cifs_swn.c | 2 +-
 fs/smb/client/cifsfs.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/smb/client/cifs_swn.c b/fs/smb/client/cifs_swn.c
index 7233c6a7e6d7..68998c6ba7a2 100644
--- a/fs/smb/client/cifs_swn.c
+++ b/fs/smb/client/cifs_swn.c
@@ -655,7 +655,7 @@ void cifs_swn_dump(struct seq_file *m)
 		seq_printf(m, "%s", swnreg->ip_notify ? "(y)" : "(n)");
 	}
 	mutex_unlock(&cifs_swnreg_idr_mutex);
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');
 }

 void cifs_swn_check(void)
diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
index 6397fdefd876..ce5cb72bb81f 100644
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
@@ -491,7 +491,7 @@ cifs_show_security(struct seq_file *s, struct cifs_ses *ses)
 	}

 	if (ses->sign)
-		seq_puts(s, "i");
+		seq_putc(s, 'i');

 	if (ses->sectype == Kerberos)
 		seq_printf(s, ",cruid=%u",
--
2.45.2