linux-kernel - Re: [PATCH v2] ASoC: codecs: wsa884x: Implement temperature reading and hwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd09fa44-1795-43a1-ba8d-ca2ba8f71d07@linaro.org>
Date: Sun, 14 Jul 2024 12:02:03 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Banajit Goswami <bgoswami@...cinc.com>, Jean Delvare <jdelvare@...e.com>,
 Guenter Roeck <linux@...ck-us.net>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
 linux-arm-msm@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: wsa884x: Implement temperature reading
 and hwmon

On 13/07/2024 11:56, Krzysztof Kozlowski wrote:
> Read temperature of the speaker and expose it via hwmon interface, which
> will be later used during calibration of speaker protection algorithms.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Changes in v2:
> 1. Add missing dependency on HWMON for y!=m builds (kernel test robot
>    report: undefined reference to
>    `devm_hwmon_device_register_with_info').
> ---
>  sound/soc/codecs/Kconfig   |   1 +
>  sound/soc/codecs/wsa884x.c | 197 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 198 insertions(+)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 97bb69c9848d..09a0b209bc2f 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -2447,6 +2447,7 @@ config SND_SOC_WSA883X
>  config SND_SOC_WSA884X
>  	tristate "WSA884X Codec"
>  	depends on SOUNDWIRE
> +	depends on HWMON || !HWMON

Eh, now I got build report that hwmon does not have stubs for !HWMON (by
design or missing?), so this still has compile failures.

I think we should have (devm_)hwmon_device_register_with_info() stubs
for drivers not depending on hwmon, so I will propose a patch for that.
If that approach is accepted, no changes should be needed in this
wsa884x v2 patchset.

Best regards,
Krzysztof