linux-kernel - [PATCH v2] kbuild: deb-pkg: fix building with bindeb-pkg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240714111356.12234-1-spasswolf@web.de>
Date: Sun, 14 Jul 2024 13:13:55 +0200
From: Bert Karwatzki <spasswolf@....de>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Bert Karwatzki <spasswolf@....de>,
	linux-kernel@...r.kernel.org,
	Andreas Schwab <schwab@...ux-m68k.org>
Subject: [PATCH v2] kbuild: deb-pkg: fix building with bindeb-pkg

Since the introduction of "set -u" into scripts/package/mkdebian running
the mkdebian scripts fails when it is called with no arguments (which is
the case when building the kernel with 'make bindeb-pkg'). This patch
introduces an additional check so mkdebian can be run without arguments.

Fixes: 8ef052389f7f ("kbuild: package: add -e and -u options to some shell scripts")

Signed-off-by: Bert Karwatzki <spasswolf@....de>
---
 scripts/package/mkdebian | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index 196b14e8ad47..fbd01175c870 100755
--- a/scripts/package/mkdebian
+++ b/scripts/package/mkdebian
@@ -135,7 +135,7 @@ else
 fi
 maintainer="${name} <${email}>"

-if [ "$1" = --need-source ]; then
+if [ $# -eq 1 ] && [ "$1" = --need-source ]; then
 	gen_source
 fi

--
2.45.2

Sorry, but the previous patch contained an embarrassing error, here's
the fixed one.

Bert Karwatzki