linux-kernel - Re: [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240715150412.655abdda@rorschach.local.home>
Date: Mon, 15 Jul 2024 15:04:12 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Tio Zhang <tiozhang@...iglobal.com>
Cc: <mhiramat@...nel.org>, <linux-kernel@...r.kernel.org>,
 <linux-trace-kernel@...r.kernel.org>, <vineethr@...ux.ibm.com>,
 <akpm@...ux-foundation.org>, <mathieu.desnoyers@...icios.com>,
 <mingo@...nel.org>, <mgorman@...hsingularity.net>, <peterz@...radead.org>,
 <qyousef@...alina.io>, <vincent.guittot@...aro.org>, <elver@...gle.com>,
 <zyhtheonly@...il.com>, <zyhtheonly@...h.net>, Peter Zijlstra
 <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, Juri Lelli
 <juri.lelli@...il.com>, Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>, Ben Segall
 <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Valentin Schneider
 <vschneid@...hat.com>
Subject: Re: [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and
 next_comm in right order


[ Adding sched maintainers, as this is a scheduling trace event ]

On Wed, 3 Jul 2024 11:33:53 +0800
Tio Zhang <tiozhang@...iglobal.com> wrote:

> Switch the order of prev_comm and next_comm in sched_switch's code to
> align with its printing order.

I'm going to pick this up in my tree, as it is pretty much a nop. It's
just changing the ordering of the assignments of the comm names so that
the copy of prev_comm is with the updates to the prev_fields, and the
next_comm is with the updates to the next fields.

-- Steve


> 
> Signed-off-by: Tio Zhang <tiozhang@...iglobal.com>
> Reviewed-by: Madadi Vineeth Reddy <vineethr@...ux.ibm.com>
> ---
>  include/trace/events/sched.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> index dbb01b4b7451..a4bd4330db4c 100644
> --- a/include/trace/events/sched.h
> +++ b/include/trace/events/sched.h
> @@ -239,11 +239,11 @@ TRACE_EVENT(sched_switch,
>  	),
>  
>  	TP_fast_assign(
> -		memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
> +		memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
>  		__entry->prev_pid	= prev->pid;
>  		__entry->prev_prio	= prev->prio;
>  		__entry->prev_state	= __trace_sched_switch_state(preempt, prev_state, prev);
> -		memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
> +		memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
>  		__entry->next_pid	= next->pid;
>  		__entry->next_prio	= next->prio;
>  		/* XXX SCHED_DEADLINE */