linux-kernel - Re: [PATCH 01/14] PCI: qcom-ep: Drop the redundant masking of global IRQ events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60254ff0-0544-47eb-864b-b7c1ff09df4a@linaro.org>
Date: Mon, 15 Jul 2024 21:57:54 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: manivannan.sadhasivam@...aro.org,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>
Cc: linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 01/14] PCI: qcom-ep: Drop the redundant masking of global
 IRQ events

On 15.07.2024 7:33 PM, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> Once the events are disabled in PARF_INT_ALL_MASK register, only the
> enabled events will generate global IRQ. So there is no need to do the
> masking again in the IRQ handler, drop it.
> 
> If there are any spurious IRQs getting generated, they will be reported
> using the existing dev_err() in the handler.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---


Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad