linux-kernel - Re: [PATCH] clk: qcom: Constify struct freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ixuyjg5os4huflsjbizfvde5kytvg6ekccjq72mpkiiiunin6y@pqkhiu6xoznk>
Date: Mon, 15 Jul 2024 09:21:17 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: Constify struct freq_tbl

On Sun, Jul 14, 2024 at 03:01:58PM GMT, Christophe JAILLET wrote:
> 'struct freq_tbl' are not modified in these drivers.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>    7595	  43696	      0	  51291	   c85b	drivers/clk/qcom/mmcc-apq8084.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>    9867	  41424	      0	  51291	   c85b	drivers/clk/qcom/mmcc-apq8084.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested-only.
> 
> I hope that it can be applied with this single patch because all files are
> in drivers/clk/qcom/.
> ---
>  drivers/clk/qcom/gcc-ipq6018.c  |  2 +-
>  drivers/clk/qcom/gcc-ipq806x.c  |  4 +--
>  drivers/clk/qcom/gcc-ipq8074.c  |  4 +--
>  drivers/clk/qcom/gcc-mdm9615.c  |  4 +--
>  drivers/clk/qcom/gcc-msm8660.c  |  4 +--
>  drivers/clk/qcom/gcc-msm8960.c  |  6 ++--
>  drivers/clk/qcom/gcc-msm8994.c  | 54 ++++++++++++++++-----------------
>  drivers/clk/qcom/gcc-msm8996.c  |  2 +-
>  drivers/clk/qcom/gcc-msm8998.c  |  2 +-
>  drivers/clk/qcom/lcc-ipq806x.c  |  8 ++---
>  drivers/clk/qcom/lcc-msm8960.c  |  8 ++---
>  drivers/clk/qcom/mmcc-apq8084.c | 50 +++++++++++++++---------------
>  drivers/clk/qcom/mmcc-msm8960.c | 30 +++++++++---------
>  drivers/clk/qcom/mmcc-msm8974.c | 52 +++++++++++++++----------------
>  drivers/clk/qcom/mmcc-msm8994.c |  8 ++---
>  drivers/clk/qcom/mmcc-msm8996.c |  8 ++---
>  16 files changed, 123 insertions(+), 123 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

-- 
With best wishes
Dmitry