linux-kernel - Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f178aa92-d91c-406d-9fea-1021bfb99f55@gmail.com>
Date: Mon, 15 Jul 2024 16:19:22 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Florian Klink <flokli@...kli.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>,
 Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Stefan Wahren <stefan.wahren@...e.com>
Subject: Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin

+Stefan,

On 7/15/24 16:03, Florian Klink wrote:
> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
> 
> This fixes HDMI hotplug/output detection.
> 
> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
> 
> Signed-off-by: Florian Klink <flokli@...kli.de>

Assuming Stefan is OK wit the change, I will apply this along with a:

Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO 
board")

> ---
>   arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
> index 72d26d130efa..85f54fa595aa 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
> @@ -77,7 +77,7 @@ &gpio {
>   };
>   
>   &hdmi {
> -	hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
> +	hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
>   	power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
>   	status = "okay";
>   };

-- 
Florian