linux-kernel - Re: [PATCH net-next v17 01/14] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <015a85bb-b775-4752-89d2-459ea6818701@intel.com>
Date: Mon, 15 Jul 2024 16:28:36 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Kory Maincent <kory.maincent@...tlin.com>, Florian Fainelli
	<florian.fainelli@...adcom.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
	"Heiner Kallweit" <hkallweit1@...il.com>, Russell King
	<linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, Radu
 Pirea <radu-nicolae.pirea@....nxp.com>, "Jay Vosburgh"
	<j.vosburgh@...il.com>, Andy Gospodarek <andy@...yhouse.net>, Nicolas Ferre
	<nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jonathan Corbet
	<corbet@....net>, "Horatiu Vultur" <horatiu.vultur@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, "Simon Horman" <horms@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, <donald.hunter@...il.com>,
	<danieller@...dia.com>, <ecree.xilinx@...il.com>
CC: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, Maxime Chevallier
	<maxime.chevallier@...tlin.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Willem de Bruijn <willemb@...gle.com>, Shannon Nelson
	<shannon.nelson@....com>, Alexandra Winter <wintera@...ux.ibm.com>
Subject: Re: [PATCH net-next v17 01/14] net_tstamp: Add TIMESTAMPING SOFTWARE
 and HARDWARE mask



On 7/9/2024 6:53 AM, Kory Maincent wrote:
> Timestamping software or hardware flags are often used as a group,
> therefore adding these masks will ease future use.
> 
> I did not use SOF_TIMESTAMPING_SYS_HARDWARE flag as it is deprecated and
> not used at all.

+1. Is there any hope of completely removing it? I'm not certain if this
is part of uAPI or not. Even so, we could make it more clear with
deprecation naming or similar.

> 
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---
> 
> Changes in v7:
> - Move the masks out of uapi to include/linux/net_tstamp.h
> 
> Changes in v9:
> - Fix commit message typos
> ---
>  include/linux/net_tstamp.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/linux/net_tstamp.h b/include/linux/net_tstamp.h
> index eb01c37e71e0..3799c79b6c83 100644
> --- a/include/linux/net_tstamp.h
> +++ b/include/linux/net_tstamp.h
> @@ -5,6 +5,14 @@
>  
>  #include <uapi/linux/net_tstamp.h>
>  
> +#define SOF_TIMESTAMPING_SOFTWARE_MASK	(SOF_TIMESTAMPING_RX_SOFTWARE | \
> +					 SOF_TIMESTAMPING_TX_SOFTWARE | \
> +					 SOF_TIMESTAMPING_SOFTWARE)
> +
> +#define SOF_TIMESTAMPING_HARDWARE_MASK	(SOF_TIMESTAMPING_RX_HARDWARE | \
> +					 SOF_TIMESTAMPING_TX_HARDWARE | \
> +					 SOF_TIMESTAMPING_RAW_HARDWARE)
> +

We can't drop _MASK because there already is SOF_TIMESTAMPING_SOFTWARE.
Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  enum hwtstamp_source {
>  	HWTSTAMP_SOURCE_NETDEV,
>  	HWTSTAMP_SOURCE_PHYLIB,
>