linux-kernel - Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552dac56-8915-4b26-8c90-769d09924861@kernel.org>
Date: Mon, 15 Jul 2024 10:57:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bingwu Zhang <xtex@...s.net>, Tony Luck <tony.luck@...el.com>,
 "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: Bingwu Zhang <xtexchooser@...k.com>, Rong Zhang <i@...g.moe>,
 Daniele Debernardi <drebrez@...il.com>, Luca Weiss <luca@...tu.xyz>,
 linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-hardening@...r.kernel.org, ~xtex/staging@...ts.sr.ht
Subject: Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node

On 15/07/2024 10:32, Bingwu Zhang wrote:
> From: Bingwu Zhang <xtexchooser@...k.com>
> 
> Add pstore node to allow for retrieving crash logs.
> 
> Tested-by: Bingwu Zhang <xtexchooser@...k.com> # on SM-G9008W (samsung-kltechn)

Tested-by tags are provided by others, not by yourself. It's expected
that you test youro own patches. Drop the tag.

> Signed-off-by: Bingwu Zhang <xtexchooser@...k.com>
> ---
>  .../qcom-msm8974pro-samsung-klte-common.dtsi    | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> index b5443fd5b425..ff98b9362b0d 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> @@ -126,6 +126,23 @@ led@3 {
>  		};
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;

Don't duplicate the nodes, but rather extend via phandle/label. Or at
least drop duplicated properties.

> +
> +		ramoops@...e0000 {
> +			compatible = "ramoops";
> +			reg = <0x3e8e0000 0x200000>;
> +
Best regards,
Krzysztof