linux-kernel - Re: linux-next: build failure after merge of the ksmbd tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mvvSQZJssVdXsYwOTCG9g_zVwHAz4fdDLqiMP6Lrn9a9w@mail.gmail.com>
Date: Sun, 14 Jul 2024 21:48:39 -0500
From: Steve French <smfrench@...il.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Namjae Jeon <linkinjeon@...nel.org>, Steve French <stfrench@...rosoft.com>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the ksmbd tree

have now updated ksmbd-for-next with the change to address this

On Sun, Jul 14, 2024 at 7:15 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> After merging the ksmbd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> fs/smb/server/vfs_cache.c:39:27: error: 'dh_task' defined but not used [-Werror=unused-variable]
>    39 | static struct task_struc *dh_task;
>       |                           ^~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   e70f0abc77e8 ("ksmbd: add durable scavenger timer")
>
> I have applied the following patch for today:
>
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Mon, 15 Jul 2024 09:55:23 +1000
> Subject: [PATCH] fixup for "ksmbd: add durable scavenger timer"
>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  fs/smb/server/vfs_cache.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/smb/server/vfs_cache.c b/fs/smb/server/vfs_cache.c
> index 2b1a5a3ebf42..4d4ee696e37c 100644
> --- a/fs/smb/server/vfs_cache.c
> +++ b/fs/smb/server/vfs_cache.c
> @@ -36,7 +36,6 @@ static struct kmem_cache *filp_cache;
>
>  static bool durable_scavenger_running;
>  static DEFINE_MUTEX(durable_scavenger_lock);
> -static struct task_struc *dh_task;
>  static wait_queue_head_t dh_wq;
>
>  void ksmbd_set_fd_limit(unsigned long limit)
> --
> 2.43.0
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve