linux-kernel - Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB495302FAFD2003B831342CF4BBA12@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Mon, 15 Jul 2024 17:55:28 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, 
	Inochi Amaoto <inochiama@...look.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property

On Mon, Jul 15, 2024 at 11:21:25AM GMT, Krzysztof Kozlowski wrote:
> On 14/07/2024 13:28, Inochi Amaoto wrote:
> > On Sophgo CV18XX platform, threshold strength of schmitt trigger can
> > be configured. As this standard property is already supported by the
> > common pinconf code. Add "input-schmitt" property in pincfg-node.yaml
> > so that other platforms requiring such feature can make use of this
> > property.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@...look.com>
> > ---
> >  Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > index d0af21a564b4..e838fcac7f2a 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > @@ -88,6 +88,10 @@ properties:
> >      description: disable input on pin (no effect on output, such as
> >        disabling an input buffer)
> > 
> > +  input-schmitt:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: threshold strength for schmitt-trigger
> 
> Strength in which units? This should have proper property name suffix.
> 
> Best regards,
> Krzysztof
> 

I think it should be mV. Using voltage may leads to decimal.