[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8506fd62-5c48-bbfa-d4ec-4ef237cbe5df@loongson.cn>
Date: Mon, 15 Jul 2024 18:35:04 +0800
From: Tiezhu Yang <yangtiezhu@...ngson.cn>
To: Xi Ruoyao <xry111@...111.site>, Josh Poimboeuf <jpoimboe@...nel.org>,
Peter Zijlstra <peterz@...radead.org>, Huacai Chen <chenhuacai@...nel.org>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 4/4] LoongArch: Remove -fno-jump-tables for objtool
On 07/13/2024 05:10 PM, Xi Ruoyao wrote:
> On Fri, 2024-07-12 at 17:49 +0800, Xi Ruoyao wrote:
>> On Fri, 2024-07-12 at 17:15 +0800, Tiezhu Yang wrote:
>>> -ifdef CONFIG_OBJTOOL
>>> -KBUILD_CFLAGS += -fno-jump-tables
>>> -endif
>>> +KBUILD_AFLAGS += $(call cc-option,-mannotate-tablejump) $(call cc-option,-Wa$(comma)-mannotate-tablejump)
>>> +KBUILD_CFLAGS += $(call cc-option,-mannotate-tablejump) $(call cc-option,-Wa$(comma)-mannotate-tablejump)
>>
>> KBUILD_AFLAGS isn't needed, and $(call cc-option,-Wa$(comma)-mannotate-
>> tablejump) will always expand to nothing because the assembler does not
>> have -mannotate-tablejump.
>>
>> The assembler never creates a jump table itself.
Thanks, you are right, I will modify it in the formal v1 series.
> BTW have you discussed with Lulu about the -mannotate-tablejump patch?
> I guess maybe an intra-Loongson discussion would be helpful.
Yes, I have discussed with Loongson compiler team some days ago
and will discuss more to reach an agreement in the next few days.
Thanks,
Tiezhu
Powered by blists - more mailing lists