linux-kernel - Re: [PATCH v3] thermal: core: Call monitor_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJZ5v0iZeAEXXVnqUccOwfu7-WEwAeXwrV-PoE4+BiOVVrOiEg@mail.gmail.com>
Date: Mon, 15 Jul 2024 12:52:56 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Stefan Lippers-Hollmann <s.l-h@....de>
Cc: Eric Biggers <ebiggers@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, 
	Linux PM <linux-pm@...r.kernel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	LKML <linux-kernel@...r.kernel.org>, Lukasz Luba <lukasz.luba@....com>, 
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, Zhang Rui <rui.zhang@...el.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, 
	"Linux regression tracking (Thorsten Leemhuis)" <regressions@...mhuis.info>
Subject: Re: [PATCH v3] thermal: core: Call monitor_thermal_zone() if zone
 temperature is invalid

On Mon, Jul 15, 2024 at 11:07 AM Stefan Lippers-Hollmann <s.l-h@....de> wrote:
>
> Hi
>
> On 2024-07-14, Eric Biggers wrote:
> > On Thu, Jul 04, 2024 at 01:46:26PM +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > >
> > > Commit 202aa0d4bb53 ("thermal: core: Do not call handle_thermal_trip()
> > > if zone temperature is invalid") caused __thermal_zone_device_update()
> > > to return early if the current thermal zone temperature was invalid.
> > >
> > > This was done to avoid running handle_thermal_trip() and governor
> > > callbacks in that case which led to confusion.  However, it went too
> > > far because monitor_thermal_zone() still needs to be called even when
> > > the zone temperature is invalid to ensure that it will be updated
> > > eventually in case thermal polling is enabled and the driver has no
> > > other means to notify the core of zone temperature changes (for example,
> > > it does not register an interrupt handler or ACPI notifier).
> > >
> > > Also if the .set_trips() zone callback is expected to set up monitoring
> > > interrupts for a thermal zone, it needs to be provided with valid
> > > boundaries and that can only be done if the zone temperature is known.
> > >
> > > Accordingly, to ensure that __thermal_zone_device_update() will
> > > run again after a failing zone temperature check, make it call
> > > monitor_thermal_zone() regardless of whether or not the zone
> > > temperature is valid and make the latter schedule a thermal zone
> > > temperature update if the zone temperature is invalid even if
> > > polling is not enabled for the thermal zone (however, if this
> > > continues to fail, give up after some time).
> > >
> > > Fixes: 202aa0d4bb53 ("thermal: core: Do not call handle_thermal_trip() if zone temperature is invalid")
> > > Reported-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> > > Link: https://lore.kernel.org/linux-pm/dc1e6cba-352b-4c78-93b5-94dd033fca16@linaro.org
> > > Link: https://lore.kernel.org/linux-pm/2764814.mvXUDI8C0e@rjwysocki.net
> > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > On v6.10 I'm seeing the following messages spammed to the kernel log endlessly,
> > and reverting this commit fixes it.
> >
> >     [  156.410567] thermal thermal_zone0: failed to read out thermal zone (-61)
> [...]
> >     [  158.458697] thermal thermal_zone0: failed to read out thermal zone (-61)
> >
> > /sys/class/thermal/thermal_zone0/type contains "iwlwifi_1".
>
> I am observing the same issue on v6.10 with an Intel ax200 WLAN
> card in a kaby-lake/ i5-7400 system and a Fujitsu D3400-B22
> mainboard and the 'newest' BIOS (V5.0.0.12 R1.29.0) as well:
>
> $ dmesg | grep -i -e iwlwifi -e thermal_zone2
> [    3.692433] iwlwifi 0000:04:00.0: enabling device (0140 -> 0142)
> [    3.698547] iwlwifi 0000:04:00.0: Detected crf-id 0x3617, cnv-id 0x100530 wfpm id 0x80000000
> [    3.698556] iwlwifi 0000:04:00.0: PCI dev 2723/0084, rev=0x340, rfid=0x10a100
> [    3.703292] iwlwifi 0000:04:00.0: TLV_FW_FSEQ_VERSION: FSEQ Version: 89.3.35.37
> [    3.797296] iwlwifi 0000:04:00.0: loaded firmware version 77.a20fb07d.0 cc-a0-77.ucode op_mode iwlmvm
> [    4.090341] iwlwifi 0000:04:00.0: Detected Intel(R) Wi-Fi 6 AX200 160MHz, REV=0x340
> [    4.090524] thermal thermal_zone2: failed to read out thermal zone (-61)
> [    4.218496] iwlwifi 0000:04:00.0: Detected RF HR B3, rfid=0x10a100
> [    4.285399] iwlwifi 0000:04:00.0: base HW address: 94:e6:f7:XX:XX:XX
> [    4.341754] iwlwifi 0000:04:00.0 wlp4s0: renamed from wlan0
> [    4.345445] thermal thermal_zone2: failed to read out thermal zone (-61)
> [    4.601400] thermal thermal_zone2: failed to read out thermal zone (-61)
> [    4.857372] thermal thermal_zone2: failed to read out thermal zone (-61)
> [    5.114387] thermal thermal_zone2: failed to read out thermal zone (-61)
> [...]
> [  143.643801] thermal thermal_zone2: failed to read out thermal zone (-61)
> [  143.899818] thermal thermal_zone2: failed to read out thermal zone (-61)
> [  144.155813] thermal thermal_zone2: failed to read out thermal zone (-61)
> [  144.411815] thermal thermal_zone2: failed to read out thermal zone (-61)
> [  144.667828] thermal thermal_zone2: failed to read out thermal zone (-61)
> [  144.923801] thermal thermal_zone2: failed to read out thermal zone (-61)
> [  145.179822] thermal thermal_zone2: failed to read out thermal zone (-61)
> [...]

As I said in the reply to the previous report, this thermal zone is
useless and it can be disabled via sysfs.  The message will go away
then.

We'll see what can be done to make the message go away completely or
at least stop being printed after a certain number of iterations.