linux-kernel - Re: [PATCH v2] clocksource: sp804: Make user selectable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZpUCzFm8Jy9TKUnk@J2N7QTR9R3>
Date: Mon, 15 Jul 2024 12:06:52 +0100
From: Mark Rutland <mark.rutland@....com>
To: Mark Brown <broonie@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	David Abdurachmanov <david.abdurachmanov@...il.com>,
	Sudeep Holla <sudeep.holla@....com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Ross Burton <ross.burton@....com>
Subject: Re: [PATCH v2] clocksource: sp804: Make user selectable

On Wed, May 29, 2024 at 08:48:14PM +0100, Mark Brown wrote:
> The sp804 is currently only user selectable if COMPILE_TEST, this was
> done by commit dfc82faad725 ("clocksource/drivers/sp804: Add
> COMPILE_TEST to CONFIG_ARM_TIMER_SP804") in order to avoid it being
> spuriously offered on platforms that won't have the hardware since it's
> generally only seen on Arm based platforms.  This config is overly
> restrictive, while platforms that rely on the SP804 do select it in
> their Kconfig there are others such as the Arm fast models which have a
> SP804 available but currently unused by Linux.  Relax the dependency to
> allow it to be user selectable on arm and arm64 to avoid surprises and
> in case someone comes up with a use for extra timer hardware.
> 
> Fixes: dfc82faad725 ("clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804")
> Reported-by: Ross Burton <ross.burton@....com>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

> ---
> Changes in v2:
> - Rebase onto v6.10-rc1.
> - Link to v1: https://lore.kernel.org/r/20240522-arm64-vexpress-sp804-v1-1-0344cd42eb77@kernel.org
> ---
>  drivers/clocksource/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 34faa0320ece..ca6045f90000 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -390,7 +390,8 @@ config ARM_GT_INITIAL_PRESCALER_VAL
>  	  This affects CPU_FREQ max delta from the initial frequency.
>  
>  config ARM_TIMER_SP804
> -	bool "Support for Dual Timer SP804 module" if COMPILE_TEST
> +	bool "Support for Dual Timer SP804 module"
> +	depends on ARM || ARM64 || COMPILE_TEST
>  	depends on GENERIC_SCHED_CLOCK && HAVE_CLK
>  	select CLKSRC_MMIO
>  	select TIMER_OF if OF
> 
> ---
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
> change-id: 20240522-arm64-vexpress-sp804-365d6938b07c
> 
> Best regards,
> -- 
> Mark Brown <broonie@...nel.org>
> 
>