linux-kernel - Re: [patch V4 00/21] genirq, irqchip: Convert ARM MSI handling to per device MSI domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpUFl4uMCT8YwkUE@hovoldconsulting.com>
Date: Mon, 15 Jul 2024 13:18:47 +0200
From: Johan Hovold <johan@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
	maz@...nel.org, anna-maria@...utronix.de, shawnguo@...nel.org,
	s.hauer@...gutronix.de, festevam@...il.com, bhelgaas@...gle.com,
	rdunlap@...radead.org, vidyas@...dia.com,
	ilpo.jarvinen@...ux.intel.com, apatel@...tanamicro.com,
	kevin.tian@...el.com, nipun.gupta@....com, den@...inux.co.jp,
	andrew@...n.ch, gregory.clement@...tlin.com,
	sebastian.hesselbarth@...il.com, gregkh@...uxfoundation.org,
	rafael@...nel.org, alex.williamson@...hat.com, will@...nel.org,
	lorenzo.pieralisi@....com, jgg@...lanox.com,
	ammarfaizi2@...weeb.org, robin.murphy@....com,
	lpieralisi@...nel.org, nm@...com, kristo@...nel.org,
	vkoul@...nel.org, okaya@...nel.org, agross@...nel.org,
	andersson@...nel.org, mark.rutland@....com,
	shameerali.kolothum.thodi@...wei.com, yuzenghui@...wei.com,
	shivamurthy.shastri@...utronix.de
Subject: Re: [patch V4 00/21] genirq, irqchip: Convert ARM MSI handling to
 per device MSI domains

On Sun, Jun 23, 2024 at 05:18:31PM +0200, Thomas Gleixner wrote:
> This is version 4 of the series to convert ARM MSI handling over to
> per device MSI domains.

> The conversion aims to replace the existing platform MSI mechanism and
> enables ARM to support the future PCI/IMS mechanism.

> The series is only lightly tested due to lack of hardware, so we rely on
> the people who have access to affected machines to help with testing.
> 
> If there are no major objections raised or testing fallout reported, I'm
> aiming this series for the next merge window.

This series only showed up in linux-next last Friday and broke interrupt
handling on Qualcomm platforms like sc8280xp (e.g. Lenovo ThinkPad X13s)
and x1e80100 that use the GIC ITS for PCIe MSIs.

I've applied the series (21 commits from linux-next) on top of 6.10 and
can confirm that the breakage is caused by commits:

	3d1c927c08fc ("irqchip/gic-v3-its: Switch platform MSI to MSI parent")
	233db05bc37f ("irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X]")

Applying the series up until the change before 3d1c927c08fc unbreaks the
wifi on one machine:

	ath11k_pci 0006:01:00.0: failed to enable msi: -22
	ath11k_pci 0006:01:00.0: probe with driver ath11k_pci failed with error -22

and backing up until the commit before 233db05bc37f makes the NVMe come
up again during boot on another.

I have not tried to debug this further.

Johan