linux-kernel - Re: [PATCH 2/5] arm64: dts: amlogic: s4: add ao secure node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5b8a25f-6d5f-490f-8526-12d260958c37@amlogic.com>
Date: Mon, 15 Jul 2024 11:31:30 +0800
From: Xianwei Zhao <xianwei.zhao@...ogic.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: amlogic: s4: add ao secure node

Hi Krzysztof,
     Thanks for your review.

On 2024/7/12 15:49, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 12/07/2024 08:54, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@...ogic.com>
>>
>> Add node for board info registers, which allows getting SoC family and
>> board revision.
>>
>> For example, with MESON_GX_SOCINFO config enabled we can get the
>> following information for board with Amlogic S4 SoC:
>> soc soc0: Amlogic S4 (S805X2) Revision 37:a (2:1) Detecte
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> index c11c947fa18c..316905ec191c 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> @@ -763,6 +763,12 @@ reset: reset-controller@...0 {
>>                                #reset-cells = <1>;
>>                        };
>>
>> +                     sec_ao: ao-secure@...20 {
>> +                             compatible = "amlogic,meson-gx-ao-secure", "syscon";
> 
> This is not gx, but s4, so incorrect compatible used. Same for all other
> patches.
>
Will use fallback to fix it.


> Best regards,
> Krzysztof
>