linux-kernel - Re: [PATCH v3] thermal: core: Call monitor_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240715145426.199c31d0@mir>
Date: Mon, 15 Jul 2024 14:54:26 +0200
From: Stefan Lippers-Hollmann <s.l-h@....de>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Eric Biggers
 <ebiggers@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM
 <linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Lukasz
 Luba <lukasz.luba@....com>, Srinivas Pandruvada
 <srinivas.pandruvada@...ux.intel.com>, Zhang Rui <rui.zhang@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v3] thermal: core: Call monitor_thermal_zone() if zone
 temperature is invalid

Hi

On 2024-07-15, Rafael J. Wysocki wrote:
> On Mon, Jul 15, 2024 at 11:09 AM Daniel Lezcano
> <daniel.lezcano@...aro.org> wrote:
> > On 15/07/2024 06:45, Eric Biggers wrote:
> > > On Thu, Jul 04, 2024 at 01:46:26PM +0200, Rafael J. Wysocki wrote:
> > >> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > >>
> > >> Commit 202aa0d4bb53 ("thermal: core: Do not call handle_thermal_trip()
[...]
> > Does the following change fixes the messages  ?
> >
> > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> > b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> > index 61a4638d1be2..b519db76d402 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> > @@ -622,7 +622,7 @@ static int iwl_mvm_tzone_get_temp(struct
> > thermal_zone_device *device,
> >
> >         if (!iwl_mvm_firmware_running(mvm) ||
> >             mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
> > -               ret = -ENODATA;
> > +               ret = -EAGAIN;
> >                 goto out;
> >         }
> >
> >
> > --
>
> It would make the message go away, but it wouldn't stop the useless
> polling of the dead thermal zone.

Silencing the warnings is already a big improvement - and that patch
works to this extent for me with an ax200, thanks.

> I think that two things need to be done:
>
> (1) Add backoff to the thermal core as proposed previously.
> (2) Make iwlwifi enable the thermal zone only if the firmware is running.

Regards
	Stefan Lippers-Hollmann