[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZpUkTZYt5DSHP5aP@J2N7QTR9R3>
Date: Mon, 15 Jul 2024 14:29:49 +0100
From: Mark Rutland <mark.rutland@....com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: remove redundant 'if HAVE_ARCH_KASAN' in Kconfig
On Sun, Jul 14, 2024 at 07:58:46PM +0900, Masahiro Yamada wrote:
> The condition 'select HAVE_ARCH_KASAN' is always true because
> there is 'select HAVE_ARCH_KASAN' statement above.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
Looks like we forgot to simplify this in commit:
0383808e4d99ac31 ("arm64: kasan: Reduce minimum shadow alignment and enable 5 level paging")
... where we began selecting HAVE_ARCH_KASAN unconditionally.
FWIW:
Acked-by: Mark Rutland <mark.rutland@....com>
Mark.
> ---
>
> arch/arm64/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index c87d16b12e9b..d37cbfc3031e 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -167,9 +167,9 @@ config ARM64
> select HAVE_ARCH_JUMP_LABEL
> select HAVE_ARCH_JUMP_LABEL_RELATIVE
> select HAVE_ARCH_KASAN
> - select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN
> - select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN
> - select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE)
> + select HAVE_ARCH_KASAN_VMALLOC
> + select HAVE_ARCH_KASAN_SW_TAGS
> + select HAVE_ARCH_KASAN_HW_TAGS if ARM64_MTE
> # Some instrumentation may be unsound, hence EXPERT
> select HAVE_ARCH_KCSAN if EXPERT
> select HAVE_ARCH_KFENCE
> --
> 2.43.0
>
>
Powered by blists - more mailing lists