linux-kernel - Re: [apparmor] [PATCH] apparmor: take nosymfollow flag into account

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8217ce983bcd4eebd43f3deb1461fb8880df7f0d.camel@canonical.com>
Date: Mon, 15 Jul 2024 11:19:09 -0300
From: Georgia Garcia <georgia.garcia@...onical.com>
To: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>, 
	john.johansen@...onical.com
Cc: stgraber@...raber.org, brauner@...nel.org, apparmor@...ts.ubuntu.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [apparmor] [PATCH] apparmor: take nosymfollow flag into account

On Fri, 2024-06-28 at 17:37 +0200, Alexander Mikhalitsyn wrote:
> A "nosymfollow" flag was added in commit
> dab741e0e02b ("Add a "nosymfollow" mount option.")
> 
> While we don't need to implement any special logic on
> the AppArmor kernel side to handle it, we should provide
> user with a correct list of mount flags in audit logs.
> 

Reviewed-by: Georgia Garcia <georgia.garcia@...onical.com>

> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>
> ---
>  security/apparmor/mount.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/security/apparmor/mount.c b/security/apparmor/mount.c
> index 49fe8da6fea4..bf8863253e07 100644
> --- a/security/apparmor/mount.c
> +++ b/security/apparmor/mount.c
> @@ -44,6 +44,8 @@ static void audit_mnt_flags(struct audit_buffer *ab, unsigned long flags)
>  		audit_log_format(ab, ", mand");
>  	if (flags & MS_DIRSYNC)
>  		audit_log_format(ab, ", dirsync");
> +	if (flags & MS_NOSYMFOLLOW)
> +		audit_log_format(ab, ", nosymfollow");
>  	if (flags & MS_NOATIME)
>  		audit_log_format(ab, ", noatime");
>  	if (flags & MS_NODIRATIME)