linux-kernel - Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=UtBhbfAAx41WWpQspK6SpCh6W5w+ogqFxogPm3omMn_A@mail.gmail.com>
Date: Mon, 15 Jul 2024 07:34:14 -0700
From: Doug Anderson <dianders@...gle.com>
To: Conor Dooley <conor@...nel.org>
Cc: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>, dmitry.torokhov@...il.com, 
	robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	jikos@...nel.org, linus.walleij@...aro.org, hsinyi@...gle.com, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Benjamin Tissoires <bentiss@...nel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

Hi,

On Mon, Jul 15, 2024 at 7:31 AM Conor Dooley <conor@...nel.org> wrote:
>
> On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv
> > <lvzhaoxiong@...qin.corp-partner.google.com> wrote:
> > >
> > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller
> > > has a reset gpio. The difference is that they have different
> > > post_power_delay_ms.
> > >
> > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
> > > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> >
> > FWIW things have changed enough between V1 and V2 that you probably
> > should have removed Conor's "Acked-by" tag here and waited for him to
> > re-add it.
>
> Yeah, good spot. I wouldn't have acked this version would asking
> questions - in v1 it made sense not to have a fallback when "they have a
> different post power delay ms", but now there is a fallback. Is the
> fallback actually suitable here, or might it be a naive rebase? Does the
> ekth6a12nay work with the ekth6915's reset timing?

Oh, good point! Yeah, it should be changed so that "ekth6915" isn't a
fallback. ...so I will rescind my Reviewed-by until that's handled.
:-/

-Doug