linux-kernel - RE: [PATCH V3 05/15] clk: imx: imx8mp-audiomix: remove sdma root clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459E0FEFFFC4F7FB257F32B88A12@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Mon, 15 Jul 2024 01:11:22 +0000
From: Peng Fan <peng.fan@....com>
To: Adam Ford <aford173@...il.com>, "Peng Fan (OSS)" <peng.fan@....nxp.com>
CC: "abelvesa@...nel.org" <abelvesa@...nel.org>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"festevam@...il.com" <festevam@...il.com>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "S.J. Wang" <shengjiu.wang@....com>
Subject: RE: [PATCH V3 05/15] clk: imx: imx8mp-audiomix: remove sdma root
 clock

> Subject: Re: [PATCH V3 05/15] clk: imx: imx8mp-audiomix: remove
> sdma root clock
> 
> On Fri, Jun 7, 2024 at 8:28 AM Peng Fan (OSS) <peng.fan@....nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@....com>
> >
> > There is an issue:
> > SDMA3 can't work without setting AUDIOMIX_CLKEN0[SDMA2] (bit-
> 26) to 1
> >
> > The workaround is:
> > As the reset state of AUDIOMIX_CLKEN0[SDMA2] is enabled, we just
> need
> > to keep it on as reset state, don't touch it in kernel, then every
> > thing is same as before, if we register the clock in clk-audiomix,
> > then kernel will try to disable it in idle.
> >
> > Fixes: 6cd95f7b151c ("clk: imx: imx8mp: Add audiomix block
> control")
> > Reviewed-by: Shengjiu Wang <shengjiu.wang@....com>
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> 
> With this patch,I found it broke the imx8mp-beacon board when
> running audio through a codec connected to sai3.  Reverting this patch
> made the crash go away.  Is there a way to mark the clock as critical so
> it doesn't get idled?

Mark it as critical means the blk ctrl needs to be powered on always.

You driver touched the SDMA2_ROOT clock?

Regards,
Peng.

> 
> adam
> >  drivers/clk/imx/clk-imx8mp-audiomix.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c
> > b/drivers/clk/imx/clk-imx8mp-audiomix.c
> > index b381d6f784c8..88d8ba975b5a 100644
> > --- a/drivers/clk/imx/clk-imx8mp-audiomix.c
> > +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> > @@ -172,7 +172,6 @@ static struct clk_imx8mp_audiomix_sel sels[]
> = {
> >         CLK_GATE("ocrama", OCRAMA_IPG),
> >         CLK_GATE("aud2htx", AUD2HTX_IPG),
> >         CLK_GATE("earc_phy", EARC_PHY),
> > -       CLK_GATE("sdma2", SDMA2_ROOT),
> >         CLK_GATE("sdma3", SDMA3_ROOT),
> >         CLK_GATE("spba2", SPBA2_ROOT),
> >         CLK_GATE("dsp", DSP_ROOT),
> > --
> > 2.37.1
> >
> >