linux-kernel - [PATCH v2] s390/cio: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240715-md-s390-drivers-s390-cio-v2-1-97eaa6971124@quicinc.com>
Date: Mon, 15 Jul 2024 08:58:51 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Peter Oberparleiter
	<oberpar@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik
	<gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        "Christian
 Borntraeger" <borntraeger@...ux.ibm.com>,
        Sven Schnelle
	<svens@...ux.ibm.com>,
        Eric Farman <farman@...ux.ibm.com>,
        Matthew Rosato
	<mjrosato@...ux.ibm.com>,
        Halil Pasic <pasic@...ux.ibm.com>
CC: <linux-s390@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kvm@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        Jeff Johnson
	<quic_jjohnson@...cinc.com>
Subject: [PATCH v2] s390/cio: add missing MODULE_DESCRIPTION() macros

With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/ccwgroup.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/vfio_ccw.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Reviewed-by: Eric Farman <farman@...ux.ibm.com>
Reviewed-by: Vineeth Vijayan <vneethv@...ux.ibm.com>
Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
---
I hope this can get into the 6.11 merge window.
I originally had almost 300 patches to fix these issues treewide, and
this is one of only 13 left which have not landed in linux-next
---
Changes in v2:
- changed CCW Group to ccwgroup in ccwgroup.c description
- removed "Physical" in vfio_ccw_drv.c description
- applied Reviewed-by tags from Eric Farman & Vineeth Vijayan since these edits
  seem to be aligned with their comments
- Link to v1: https://lore.kernel.org/r/20240615-md-s390-drivers-s390-cio-v1-1-8fc9584e8595@quicinc.com
---
 drivers/s390/cio/ccwgroup.c     | 1 +
 drivers/s390/cio/vfio_ccw_drv.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index b72f672a7720..66b1bdc63284 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -550,4 +550,5 @@ void ccwgroup_remove_ccwdev(struct ccw_device *cdev)
 	put_device(&gdev->dev);
 }
 EXPORT_SYMBOL(ccwgroup_remove_ccwdev);
+MODULE_DESCRIPTION("ccwgroup bus driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 8ad49030a7bf..914dde041675 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -488,4 +488,5 @@ static void __exit vfio_ccw_sch_exit(void)
 module_init(vfio_ccw_sch_init);
 module_exit(vfio_ccw_sch_exit);
 
+MODULE_DESCRIPTION("VFIO based Subchannel device driver");
 MODULE_LICENSE("GPL v2");

---
base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd
change-id: 20240615-md-s390-drivers-s390-cio-3598abb802ad