linux-kernel - Re: [PATCH] dt-bindings: clock: qcom,turingcc: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240715-colony-hacksaw-6729fca296c6@spud>
Date: Mon, 15 Jul 2024 17:12:31 +0100
From: Conor Dooley <conor@...nel.org>
To: Rayyan Ansari <rayyan.ansari@...aro.org>
Cc: devicetree@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: qcom,turingcc: convert to dtschema

On Mon, Jul 15, 2024 at 05:11:49PM +0100, Conor Dooley wrote:
> On Mon, Jul 15, 2024 at 09:43:10AM +0100, Rayyan Ansari wrote:
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,turingcc.yaml
> > new file mode 100644
> > index 000000000000..0a57e42fb4d9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,turingcc.yaml
> 
> filename should match the compatible in the binding.
> 
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,turingcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Turing Clock & Reset Controller
> > +
> > +maintainers:
> > +  - Bjorn Andersson <andersson@...nel.org>
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,qcs404-turingcc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - '#clock-cells'
> > +  - '#reset-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/qcom,gcc-qcs404.h>
> > +    turingcc: clock-controller@...000 {
> 
> nit: drop the label
> 
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>

gah, I forgot to say that ack was conditional on the filename being
changed.

> 
> Cheers,
> Conor.
> 
> > +        compatible = "qcom,qcs404-turingcc";
> > +        reg = <0x00800000 0x30000>;
> > +        clocks = <&gcc GCC_CDSP_CFG_AHB_CLK>;
> > +
> > +        #clock-cells = <1>;
> > +        #reset-cells = <1>;
> > +    };
> > -- 
> > 2.45.2
> > 



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)