linux-kernel - Re: [PATCH] arm64: dts: qcom: disable GPU on x1e80100 by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51feb2aa-adfd-415d-8329-0512e817e9bd@linaro.org>
Date: Mon, 15 Jul 2024 19:25:48 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Johan Hovold <johan@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Akhil P Oommen <quic_akhilpo@...cinc.com>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: disable GPU on x1e80100 by default

On 15.07.2024 6:44 PM, Johan Hovold wrote:
> On Mon, Jul 15, 2024 at 07:40:22PM +0300, Dmitry Baryshkov wrote:
>> On Mon, 15 Jul 2024 at 17:44, Johan Hovold <johan@...nel.org> wrote:
>>>
>>> On Mon, Jul 15, 2024 at 05:23:58PM +0300, Dmitry Baryshkov wrote:
>>>> The GPU on X1E80100 requires ZAP 'shader' file to be useful. Since the
>>>> file is signed by the OEM keys and might be not available by default,
>>>> disable the GPU node and drop the firmware name from the x1e80100.dtsi
>>>> file. Devices not being fused to use OEM keys can specify generic
>>>> location at `qcom/x1e80100/gen70500_zap.mbn` while enabling the GPU.
>>>
>>> Please enable the GPU for the CRD as part of this patch (e.g. move the
>>> fw name property there).
>>
>> I can not just move the property, as it is going to have a different
>> value. I think GPU enablement for CRD should come as a separate patch.
> 
> The GPU is already enabled, this patch is effectively disabling it
> unless you move (and update) the corresponding properties to the CRD

Right, sorry about not noticing this.

Dmitry, please do as Johan suggests here, taking care of the commit
you sent to linux-firmware moving stuff around..

Konrad