linux-kernel - Re: [PATCH] vfio-mdev: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac6de49a-a130-41eb-87b5-0ecd1e05840b@quicinc.com>
Date: Mon, 15 Jul 2024 10:32:38 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Alex Williamson <alex.williamson@...hat.com>
CC: Kirti Wankhede <kwankhede@...dia.com>,
        "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] vfio-mdev: add MODULE_DESCRIPTION() macros

On 7/15/2024 9:35 AM, Alex Williamson wrote:
> On Mon, 15 Jul 2024 09:17:41 -0700
> Jeff Johnson <quic_jjohnson@...cinc.com> wrote:
> 
>> On 7/12/2024 3:36 PM, Alex Williamson wrote:>>>>   MODULE_LICENSE("GPL v2");
>>>>>>   MODULE_INFO(supported, "Test driver that simulate serial port over PCI");
>>>>>> +MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");  
>>>
>>> Seems the preceding MODULE_INFO needs to be removed here.  At best the
>>> added MODULE_DESCRIPTION is redundant, but "supported" is not a
>>> standard tag, so it's not clear what the purpose of that tag was meant
>>> to be anyway.  Thanks,
>>>
>>> Alex  
>>
>> My preference would be to just add the missing MODULE_DESCRIPTION() with this
>> patch since that fixes the existing warning. Removing an existing macro
>> invocation is out of scope for what I'm trying to accomplish.
> 
> This adds a MODULE_DESCRIPTION that's redundant to the current
> MODULE_INFO, therefore I'd argue that it's not out of scope to replace
> the MODULE_INFO with a MODULE_DESCRIPTION to achieve your goal.  Thanks,
> 
> Alex
> 
ok, let me post a v2

/jeff