linux-kernel - Re: [RFC PATCH net-next v6 03/14] af_vsock: support multi-transport datagrams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMB2axN5jJ_uabb-rd=wdcbX9DQYvENxQjK_7ZWhM60+5fVLKA@mail.gmail.com>
Date: Mon, 15 Jul 2024 10:41:40 -0700
From: Amery Hung <ameryhung@...il.com>
To: Arseniy Krasnov <avkrasnov@...utedevices.com>
Cc: stefanha@...hat.com, sgarzare@...hat.com, mst@...hat.com, 
	jasowang@...hat.com, xuanzhuo@...ux.alibaba.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, kys@...rosoft.com, 
	haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com, 
	bryantan@...are.com, vdasa@...are.com, pv-drivers@...are.com, 
	dan.carpenter@...aro.org, simon.horman@...igine.com, oxffffaa@...il.com, 
	kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-hyperv@...r.kernel.org, bpf@...r.kernel.org, 
	bobby.eshleman@...edance.com, jiang.wang@...edance.com, 
	amery.hung@...edance.com, xiyou.wangcong@...il.com, 
	kernel <kernel@...rdevices.ru>
Subject: Re: [RFC PATCH net-next v6 03/14] af_vsock: support multi-transport datagrams

On Mon, Jul 15, 2024 at 1:25 AM Arseniy Krasnov
<avkrasnov@...utedevices.com> wrote:
>
> Hi! Sorry, i was not in cc, so I'll reply in this way :)

Ope. I will copy you in the next version.

>
> +static const struct vsock_transport *
> +vsock_dgram_lookup_transport(unsigned int cid, __u8 flags)
> +{
> +       const struct vsock_transport *transport;
> +
> +       transport = vsock_connectible_lookup_transport(cid, flags);
> +       if (transport)
> +               return transport;
> +
> +       return transport_dgram_fallback;
> +}
> +
> ^^^
>
> I guess this must be under EXPORT_SYMBOL, because it is called from
> virtio_transport_common.c, so module build fails.
>
> Thanks

Right. I will fix it by exporting vsock_dgram_lookup_transport() in patch 7.

Thanks!
Amery