linux-kernel - Re: [PATCH v3 1/1] watchdog: imx7ulp_wdt: move post_rcs_wait into struct imx_wdt_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57b1d9da-ea7a-4df8-bc02-a3c9db4f28da@roeck-us.net>
Date: Mon, 15 Jul 2024 11:01:57 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Fabio Estevam <festevam@...il.com>, Frank Li <Frank.Li@....com>
Cc: alice.guo@....com, imx@...ts.linux.dev, kernel@...gutronix.de,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-watchdog@...r.kernel.org, s.hauer@...gutronix.de, shawnguo@...nel.org,
 wim@...ux-watchdog.org, ye.li@....com
Subject: Re: [PATCH v3 1/1] watchdog: imx7ulp_wdt: move post_rcs_wait into
 struct imx_wdt_hw_feature

On 7/15/24 10:16, Fabio Estevam wrote:
> Hi Frank,
> 
> On Mon, Jul 15, 2024 at 2:07 PM Frank Li <Frank.Li@....com> wrote:
>>
>> Move post_rcs_wait into struct imx_wdt_hw_feature to simplify code logic
>> for different compatible strings
>>
>> i.MX93 and i.MX8ULP watchdog do not need to wait 2.5 clocks after RCS is
>> done. Set post_rcs_wait to false explicitly to maintain code consistency.
>>
>> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>> Signed-off-by: Alice Guo <alice.guo@....com>
>> Reviewed-by: Ye Li <ye.li@....com>
>> Signed-off-by: Frank Li <Frank.Li@....com>
> 
> It looks better now, thanks:
> 

Not in my opinion. As requested in my other e-mail, please drop my Reviewed-by: tag.

Guenter

> Reviewed-by: Fabio Estevam <festevam@...il.com>