linux-kernel - Re: [PATCH] workqueue: Remove unneeded lockdep_assert_cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpVpDqhO8B8_iKL5@slm.duckdns.org>
Date: Mon, 15 Jul 2024 08:23:10 -1000
From: Tejun Heo <tj@...nel.org>
To: Lai Jiangshan <jiangshanlai@...il.com>
Cc: linux-kernel@...r.kernel.org,
	Lai Jiangshan <jiangshan.ljs@...group.com>,
	kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH] workqueue: Remove unneeded lockdep_assert_cpus_held()

Hello,

On Tue, Jul 16, 2024 at 01:29:31AM +0800, Lai Jiangshan wrote:
> @@ -6906,7 +6898,6 @@ static int wq_affn_dfl_set(const char *val, const struct kernel_param *kp)
>  	if (affn == WQ_AFFN_DFL)
>  		return -EINVAL;
>  
> -	cpus_read_lock();
>  	mutex_lock(&wq_pool_mutex);
>  
>  	wq_affn_dfl = affn;
> @@ -6917,7 +6908,6 @@ static int wq_affn_dfl_set(const char *val, const struct kernel_param *kp)
>  	}
>  
>  	mutex_unlock(&wq_pool_mutex);
> -	cpus_read_unlock();

This part isn't explained in the patch description. Can you separate it out
to a separate patch or add description in this patch?

Thanks.

-- 
tejun