linux-kernel - Re: [GIT PULL 2/4] soc: dt updates for 6.11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whp2O+NjOXf77hfATgEe-LHTefbFb0eR=ytQUJTOUnfdQ@mail.gmail.com>
Date: Tue, 16 Jul 2024 11:55:45 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	soc@...nel.org
Subject: Re: [GIT PULL 2/4] soc: dt updates for 6.11

On Mon, 15 Jul 2024 at 14:03, Arnd Bergmann <arnd@...db.de> wrote:
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/soc-dt-6.11

WTF, Arnd?

This doesn't even *build*:

> Jagadeesh Kona (8):
>       clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver

because it has

        ret = qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8650_desc, regmap);

which is entirely wrong.

And no, this is not some kind of merge mistake of mine. It was wrong
in your tree.

qcom_cc_really_probe() has always taken a

    struct platform_device *pdev

as the first argument, not a "struct device *". So the "&pdev->dev"
thing is completely wrong, and always has been.

Looking around, this was also reported by the kernel test robot at

    https://lore.kernel.org/all/202407072331.baglL4Sd-lkp@intel.com/
    https://lore.kernel.org/all/202407072212.WptVaUDt-lkp@intel.com/

and still I had to just notice it in my local build test.

I did fix it up, but this is *not* ok.

               Linus