linux-kernel - Re: [PATCH 2/3] dt-bindings: ata: qcom,ipq806x-ahci: use dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94572710-f90e-4ac6-a0f8-02d93404fb92@kernel.org>
Date: Tue, 16 Jul 2024 21:46:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rayyan Ansari <rayyan.ansari@...aro.org>, devicetree@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Cc: Bjorn Andersson <andersson@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Damien Le Moal <dlemoal@...nel.org>,
 de Goede <hdegoede@...hat.com>, Jens Axboe <axboe@...nel.dk>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-ide@...r.kernel.org,
 linux-kernel@...r.kernel.org, Niklas Cassel <cassel@...nel.org>,
 Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 2/3] dt-bindings: ata: qcom,ipq806x-ahci: use dtschema

On 16/07/2024 12:46, Rayyan Ansari wrote:
> Remove old text bindings and add ipq806x AHCI compatible to
> ahci-common.yaml, as well as its required properties.
> 

>  
>  allOf:
>    - $ref: ahci-common.yaml#
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,ipq806x-ahci
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 5
> +        clock-names:
> +          items:
> +            - const: slave_iface
> +            - const: iface
> +            - const: core
> +            - const: rxoob
> +            - const: pmalive
> +        assigned-clocks:
> +          minItems: 2
> +          maxItems: 2
> +        assigned-clock-rates:


assigned* should not be needed in the binding. You can drop these.

> +          items:
> +            - const: 100000000
> +            - const: 100000000
> +      required:
> +        - phys
> +        - phy-names
> +        - clocks
> +        - clock-names
> +        - assigned-clocks
> +        - assigned-clock-rates

Also from here.


Best regards,
Krzysztof