[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2101274.K71DO8KEF6@diego>
Date: Tue, 16 Jul 2024 22:07:56 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Christopher Obbard <chris.obbard@...labora.com>,
Dragan Simic <dsimic@...jaro.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org, Kever Yang <kever.yang@...k-chips.com>
Subject: Re: [PATCH 0/2] Add support for Firefly CORE PX30 JD4
Am Dienstag, 16. Juli 2024, 19:45:44 CEST schrieb Dragan Simic:
> Hello Christopher,
>
> On 2024-07-16 17:51, Christopher Obbard wrote:
> > The Firefly CORE PX30 JD4 board is a SOM and motherboard bundle from
> > Firefly containing the Rockchip PX30 SOC. This series adds support for
> > it.
> >
> > ---
> > Christopher Obbard (2):
> > dt-bindings: arm: rockchip: add Firefly CORE PX30 JD4
> > arm64: dts: rockchip: add Firefly CORE PX30 JD4
> >
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../dts/rockchip/px30-firefly-core-px30-jd4.dts | 562
> > +++++++++++++++++++++
> > 3 files changed, 568 insertions(+)
>
> It would be better to split this into two separate files: a dtsi
> for the SoM, and a dts for the carrier board (which would include
> the new dtsi). That would reflect the actual hardware better.
correct :-) .
There are numerous examples of these types in the kernel
already, both these combinations - for inspiration :-) .
Powered by blists - more mailing lists