linux-kernel - Re: [PATCH 0/6] mfd: add adp5585 gpio and pwm support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172116301291.347275.15990094913310761465.robh@kernel.org>
Date: Tue, 16 Jul 2024 15:12:36 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: imx@...ts.linux.dev, Conor Dooley <conor+dt@...nel.org>, 
 Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org, 
 Jun Li <jun.li@....com>, Jindong Yue <jindong.yue@....com>, 
 linux-kernel@...r.kernel.org, 
 Uwe Kleine-König <ukleinek@...nel.org>, 
 Bartosz Golaszewski <brgl@...ev.pl>, Clark Wang <xiaoning.wang@....com>, 
 linux-arm-kernel@...ts.infradead.org, linux-pwm@...r.kernel.org, 
 Lee Jones <lee@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
 linux-gpio@...r.kernel.org, Haibo Chen <haibo.chen@....com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Sascha Hauer <s.hauer@...gutronix.de>, Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH 0/6] mfd: add adp5585 gpio and pwm support


On Tue, 16 Jul 2024 15:28:23 -0400, Frank Li wrote:
> adp5585 is totally difference adp5588, which in
> drivers/input/keyboard/adp5588-keys.c.
> 
> So create new driver for it.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Clark Wang (1):
>       pwm: adp5585: add adp5585 PWM support
> 
> Frank Li (3):
>       dt-bindings: mfd: Add i2c device adi5585
>       arm64: dts: imx93-11x11-evk: add adi,adp5585 gpio and pwm
>       arm64: dts: imx95-19x19-evk: add i2c2 and adi,adp5585
> 
> Haibo Chen (2):
>       mfd: adp5585: add ADI adp5585 core support
>       gpio: adp5585-gpio: add adp5585-gpio support
> 
>  .../devicetree/bindings/mfd/adi,adp5585.yaml       |  83 ++++++++
>  arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts  |  16 ++
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts  |  30 +++
>  drivers/gpio/Kconfig                               |   7 +
>  drivers/gpio/Makefile                              |   1 +
>  drivers/gpio/gpio-adp5585.c                        | 184 ++++++++++++++++++
>  drivers/mfd/Kconfig                                |   9 +
>  drivers/mfd/Makefile                               |   1 +
>  drivers/mfd/adp5585.c                              | 134 +++++++++++++
>  drivers/pwm/Kconfig                                |   8 +
>  drivers/pwm/Makefile                               |   1 +
>  drivers/pwm/pwm-adp5585.c                          | 215 +++++++++++++++++++++
>  include/linux/mfd/adp5585.h                        | 100 ++++++++++
>  13 files changed, 789 insertions(+)
> ---
> base-commit: 91e3b24eb7d297d9d99030800ed96944b8652eaf
> change-id: 20240715-adi-11ff2d3d35ec
> 
> Best regards,
> ---
> Frank Li <Frank.Li@....com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx93-11x11-evk.dtb freescale/imx95-19x19-evk.dtb' for 20240716-adi-v1-0-79c0122986e7@....com:

arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: mfd@34: 'gpio', 'pwm' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: mfd@34: 'gpio-adp5585', 'pwm-adp5585' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#