linux-kernel - Re: [PATCH] drm/msm/adreno: Fix error return if missing firmware-name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240716214601.4th2ukmy7zzvhs4g@hu-akhilpo-hyd.qualcomm.com>
Date: Wed, 17 Jul 2024 03:16:01 +0530
From: Akhil P Oommen <quic_akhilpo@...cinc.com>
To: Rob Clark <robdclark@...il.com>
CC: <dri-devel@...ts.freedesktop.org>, <linux-arm-msm@...r.kernel.org>,
        <freedreno@...ts.freedesktop.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>,
        Rob Clark <robdclark@...omium.org>, Sean Paul
	<sean@...rly.run>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Abhinav Kumar
	<quic_abhinavk@...cinc.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/adreno: Fix error return if missing firmware-name

On Tue, Jul 16, 2024 at 09:06:30AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@...omium.org>
> 
> -ENODEV is used to signify that there is no zap shader for the platform,
> and the CPU can directly take the GPU out of secure mode.  We want to
> use this return code when there is no zap-shader node.  But not when
> there is, but without a firmware-name property.  This case we want to
> treat as-if the needed fw is not found.
> 
> Signed-off-by: Rob Clark <robdclark@...omium.org>
> ---

Reviewed-by: Akhil P Oommen <quic_akhilpo@...cinc.com>

-Akhil

>  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index b46e7e93b3ed..0d84be3be0b7 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -99,7 +99,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
>  		 * was a bad idea, and is only provided for backwards
>  		 * compatibility for older targets.
>  		 */
> -		return -ENODEV;
> +		return -ENOENT;
>  	}
>  
>  	if (IS_ERR(fw)) {
> -- 
> 2.45.2
>