linux-kernel - Re: [PATCH v2] phy: cadence-torrent: add support for three or more links using 2 protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf060fa7-f4e5-4740-8102-f9403cbfcafd@ti.com>
Date: Tue, 16 Jul 2024 09:34:02 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Roger Quadros <rogerq@...nel.org>
CC: Siddharth Vadapalli <s-vadapalli@...com>,
        Swapnil Kashinath Jakhade
	<sjakhade@...ence.com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "kishon@...nel.org" <kishon@...nel.org>,
        "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>,
        "thomas.richard@...tlin.com"
	<thomas.richard@...tlin.com>,
        "theo.lebrun@...tlin.com"
	<theo.lebrun@...tlin.com>,
        "robh@...nel.org" <robh@...nel.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "srk@...com" <srk@...com>, Milind
 Parab <mparab@...ence.com>
Subject: Re: [PATCH v2] phy: cadence-torrent: add support for three or more
 links using 2 protocols

On Mon, Jul 15, 2024 at 07:08:30PM +0300, Roger Quadros wrote:
> Hi Siddhath,
> 
> On 12/07/2024 13:38, Siddharth Vadapalli wrote:
> > Roger, Swapnil,
> > 

[...]

> > So assuming the above, we can enforce the constraint that there should
> > be only 2 Protocols when 3 or more Links are present in the device-tree.
> > This also handles the cases of
> > PCIe Multi-Link + USB, PCIe Multi-Link + Q/SGMII
> > which Swapnil has pointed to at [1], since PCIe Multi-Link is now a new
> > protocol in itself (PHY_TYPE_PCIE_ML) and shall be represented in that
> > manner in the device-tree when it is expected to be combined with a second
> > protocol.
> > 
> > After grouping the links by protocol, we can check for the entry in
> > "link_cmn_vals_entries" and proceed to configure it identical to the
> > 2 Link case.
> > 
> > [1] https://github.com/t-c-collab/linux/commits/ti-linux-6.1.y-torrent-multi-pcie-sgmii-v1
> 
> This proposal looks good to me. Thanks!

Thank you for the confirmation. I will implement the above in the v3
patch.

Regards,
Siddharth.