linux-kernel - [PATCH 0/5] platform/x86: introduce asus-bioscfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240716051612.64842-1-luke@ljones.dev>
Date: Tue, 16 Jul 2024 17:16:07 +1200
From: "Luke D. Jones" <luke@...nes.dev>
To: platform-driver-x86@...r.kernel.org
Cc: corentin.chary@...il.com,
	hdegoede@...hat.com,
	ilpo.jarvinen@...ux.intel.com,
	mario.limonciello@....com,
	linux-kernel@...r.kernel.org,
	"Luke D. Jones" <luke@...nes.dev>
Subject: [PATCH 0/5] platform/x86: introduce asus-bioscfg

This is the first major patch I've ever done with the intention of
introducing a new module, so it's highly likely I've made some mistakes
or misunderstood something.

TL;DR:
1. introduce new module to contain bios attributes, using fw_attributes_class
2. deprecate all possible attributes from asus-wmi that were added ad-hoc
3. remove those in the next LTS cycle

The idea for this originates from a conversation with Mario Limonciello
https://lore.kernel.org/platform-driver-x86/371d4109-a3bb-4c3b-802f-4ec27a945c99@amd.com/

It is without a doubt much cleaner to use, easier to discover, and the
API is well defined as opposed to the random clutter of attributes I had
been placing in the platform sysfs.

The review of this patch series will also affect my next patch set which
is for the ROG Ally (2k LOC) as I've used a similar strategy for the
macros to reduce LOC as much as possible.

In regards to *this* patch series though, I think the critical areas
might be the use of the mutex, the macros, possibly the way I've setup
the module to load/depend on asus-wmi (I had to read other code to try
and define the way).

I am unsure of how best to handle the deprecation of attributes.

There's also some attributes that are obviously boolean but are using 0/1.
I'm unsure if I should change that.

And would it be best to move the asus stuff to a subdir now? Akin to the
Dell platform stuff.

All guidance deeply appreciated to get this over the line.

Regards,
Luke

Luke D. Jones (5):
  platform/x86 asus-bioscfg: move existing tunings to asus-bioscfg
    module
  platform/x86: asus-bioscfg: add dgpu tgp control
  platform/x86: asus-bioscfg: add apu-mem control support
  platform/x86: asus-bios: add core count control
  asus-wmi: deprecate bios features

 .../ABI/testing/sysfs-platform-asus-wmi       |  17 +
 drivers/platform/x86/Kconfig                  |  22 +
 drivers/platform/x86/Makefile                 |   1 +
 drivers/platform/x86/asus-bioscfg.c           | 997 ++++++++++++++++++
 drivers/platform/x86/asus-bioscfg.h           | 302 ++++++
 drivers/platform/x86/asus-wmi.c               | 144 ++-
 include/linux/platform_data/x86/asus-wmi.h    |  19 +
 7 files changed, 1473 insertions(+), 29 deletions(-)
 create mode 100644 drivers/platform/x86/asus-bioscfg.c
 create mode 100644 drivers/platform/x86/asus-bioscfg.h

-- 
2.45.2