linux-kernel - Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpYxkH1EFB65tEzt@tiehlicka>
Date: Tue, 16 Jul 2024 10:38:40 +0200
From: Michal Hocko <mhocko@...e.com>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: akpm@...ux-foundation.org, nao.horiguchi@...il.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in
 pfn_inject_exit()

On Tue 16-07-24 11:35:16, Miaohe Lin wrote:
> When hwpoison_inject module is removed, hwpoison_filter_* parameters
> should be reset. Otherwise these parameters will have non-default values
> at next insmod time.

There is a clear layering broken here. We have mm/memory-failure.c using
values and mm/hwpoison-inject.c defining the values. Both with a
potentially different life time. Shouldn't that be fix instead?
-- 
Michal Hocko
SUSE Labs