linux-kernel - Re: [PATCH] spi: meson-spicc: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56a90ea2-6bba-42ef-b615-61f8c797e09c@linaro.org>
Date: Tue, 16 Jul 2024 11:31:12 +0200
From: neil.armstrong@...aro.org
To: Chen Ni <nichen@...as.ac.cn>, broonie@...nel.org, khilman@...libre.com,
 jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
 yixun.lan@...ogic.com, sunny.luo@...ogic.com
Cc: linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: meson-spicc: convert comma to semicolon

On 16/07/2024 11:11, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: 3e0cf4d3fc29 ("spi: meson-spicc: add a linear clock divider support")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/spi/spi-meson-spicc.c | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index 8838a98b04c2..1d05590a7434 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -655,8 +655,8 @@ static int meson_spicc_pow2_clk_init(struct meson_spicc_device *spicc)
>   	}
>   	init.num_parents = 1;
>   
> -	pow2_fixed_div->mult = 1,
> -	pow2_fixed_div->div = 4,
> +	pow2_fixed_div->mult = 1;
> +	pow2_fixed_div->div = 4;
>   	pow2_fixed_div->hw.init = &init;
>   
>   	clk = devm_clk_register(dev, &pow2_fixed_div->hw);
> @@ -674,9 +674,9 @@ static int meson_spicc_pow2_clk_init(struct meson_spicc_device *spicc)
>   	parent_data[0].hw = &pow2_fixed_div->hw;
>   	init.num_parents = 1;
>   
> -	spicc->pow2_div.shift = 16,
> -	spicc->pow2_div.width = 3,
> -	spicc->pow2_div.flags = CLK_DIVIDER_POWER_OF_TWO,
> +	spicc->pow2_div.shift = 16;
> +	spicc->pow2_div.width = 3;
> +	spicc->pow2_div.flags = CLK_DIVIDER_POWER_OF_TWO;
>   	spicc->pow2_div.reg = spicc->base + SPICC_CONREG;
>   	spicc->pow2_div.hw.init = &init;
>   
> @@ -721,8 +721,8 @@ static int meson_spicc_enh_clk_init(struct meson_spicc_device *spicc)
>   	}
>   	init.num_parents = 1;
>   
> -	enh_fixed_div->mult = 1,
> -	enh_fixed_div->div = 2,
> +	enh_fixed_div->mult = 1;
> +	enh_fixed_div->div = 2;
>   	enh_fixed_div->hw.init = &init;
>   
>   	clk = devm_clk_register(dev, &enh_fixed_div->hw);
> @@ -740,8 +740,8 @@ static int meson_spicc_enh_clk_init(struct meson_spicc_device *spicc)
>   	parent_data[0].hw = &enh_fixed_div->hw;
>   	init.num_parents = 1;
>   
> -	enh_div->shift	= 16,
> -	enh_div->width	= 8,
> +	enh_div->shift	= 16;
> +	enh_div->width	= 8;
>   	enh_div->reg = spicc->base + SPICC_ENH_CTL0;
>   	enh_div->hw.init = &init;
>   
> @@ -761,8 +761,8 @@ static int meson_spicc_enh_clk_init(struct meson_spicc_device *spicc)
>   	init.num_parents = 2;
>   	init.flags = CLK_SET_RATE_PARENT;
>   
> -	mux->mask = 0x1,
> -	mux->shift = 24,
> +	mux->mask = 0x1;
> +	mux->shift = 24;
>   	mux->reg = spicc->base + SPICC_ENH_CTL0;
>   	mux->hw.init = &init;
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>