linux-kernel - Re: [PATCH] x86,spinlock: make disabling virt_spin_lock_key contingent on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e8f7fd6-72d1-41dd-a7d9-914d7f73c46c@suse.com>
Date: Tue, 16 Jul 2024 11:41:23 +0200
From: Jürgen Groß <jgross@...e.com>
To: Rik van Riel <riel@...riel.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Arnd Bergmann <arnd@...db.de>,
 linux-kernel@...r.kernel.org, x86@...nel.org, Ingo Molnar
 <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, kernel-team@...a.com
Subject: Re: [PATCH] x86,spinlock: make disabling virt_spin_lock_key
 contingent on CONFIG_PARAVIRT

On 15.07.24 19:18, Rik van Riel wrote:
> The existence of virt_spin_lock_key is contingent only on CONFIG_PARAVIRT, not
> on CONFIG_PARAVIRT_SPINLOCKS.
> 
> As a result, a kernel with CONFIG_PARAVIRT enabled, but CONFIG_PARAVIRT_SPINLOCKS
> disabled will end up disabling queued spinlocks when running on bare metal.
> 
> Making the disabling of virt_spin_lock_key contingent on CONFIG_PARAVIRT, which
> controls whether the key exists, results in queued spinlocks being enabled on
> bare metal again.
> 
> Signed-off-by: Rik van Riel <riel@...riel.com>
> Cc: stable@...r.kernel.org
> Fixes: ce0a1b608bfc ("x86/paravirt: Silence unused native_pv_lock_init() function warning")

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen