linux-kernel - Re: [GIT PULL] regulator updates for v6.11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wg03gdyDBv8ep-UmL=QdNr3278Oa21o93Eiysy8gDoJNw@mail.gmail.com>
Date: Mon, 15 Jul 2024 18:15:27 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] regulator updates for v6.11

On Mon, 15 Jul 2024 at 07:15, Mark Brown <broonie@...nel.org> wrote:
>
>  - Support for Mediaktek MT6312, Qualcomm QCA6390 and WCN7850, Renesas
>    RZ/G2L USB VBUS regulator and ST Microelectronics STM32MP13.

Grr. My arm64 testing shows that this is

    default ARCH_RZG2L

and turns on automatically, which might make sense if ARCH_RZG2L was
some kind of "I'm building for this platform".

But it's a pretty generic thing that turns on very easily by a lot of
random things, and ARCH_RZG2L a 'bool' anyway, so this thing that is a
tristate now effectively defaults to be built-in.

Please - new support should NOT DEFAULT TO ON. Not even when you think
"it makes sense". Not unless it's something that was on previously,
and was split out, and is now available under a separate config option
name.

IOW - if things worked without it before, it should damn well not
magically turn on just because somebody did a "make oldconfig".

               Linus