linux-kernel - Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1d7b58c-b605-4adc-b329-f74ea4567982@linaro.org>
Date: Tue, 16 Jul 2024 13:58:44 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Ulf Hansson <ulf.hansson@...aro.org>,
 Krzysztof Kozlowski <krzk@...nel.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
 Stephen Boyd <sboyd@...nel.org>, Niklas Cassel <nks@...wful.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Robert Marko
 <robimarko@...il.com>, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-pm@...r.kernel.org, Jeffrey Hugo <quic_jhugo@...cinc.com>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Varadarajan Narayanan <quic_varada@...cinc.com>
Subject: Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers
 in the file list

On 15.07.2024 1:34 PM, Ulf Hansson wrote:
> On Tue, 9 Jul 2024 at 16:42, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 09/07/2024 11:49, Konrad Dybcio wrote:
>>> On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote:
>>>> On 08/07/2024 14:22, Konrad Dybcio wrote:
>>>>> Expand the Qualcomm Core Power Reduction section to include the files
>>>>> concerning CPR3+ support.
>>>>>
>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>>>> ---
>>>>>  MAINTAINERS | 5 +++--
>>>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index dcb37b635f2c..f3e013a52c16 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -18687,14 +18687,15 @@ F:        Documentation/accel/qaic/
>>>>>  F: drivers/accel/qaic/
>>>>>  F: include/uapi/drm/qaic_accel.h
>>>>>
>>>>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
>>>>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
>>>>>  M: Bjorn Andersson <andersson@...nel.org>
>>>>>  M: Konrad Dybcio <konrad.dybcio@...aro.org>
>>>>>  L: linux-pm@...r.kernel.org
>>>>>  L: linux-arm-msm@...r.kernel.org
>>>>>  S: Maintained
>>>>>  F: Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
>>>>> -F: drivers/pmdomain/qcom/cpr.c
>>>>> +F: Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
>>>>
>>>> Maybe combine these two into:
>>>> Documentation/devicetree/bindings/power/avs/qcom,cpr*
>>>
>>> I think avs was proposed to be a subsystem/driver directory at some point
>>> and (adaptive voltage source? something like that) and this is the only file
>>> in that directory in bindings..
>>>
>>> Should we continue with this "class" of devices, or should I move qcom,cpr.yaml
>>> to soc?
>>
>> Rather cpr3 should be moved to avs or some other power directory. "soc"
>> is fallback, junkyard for things without clear domain.
> 
> In my opinion, I would suggest dropping the
> "Documentation/devicetree/bindings/power/avs/" directory. We already
> have similar bindings sprinkled across various directories, see below.
> One less seems better to me.
> 
> Documentation/devicetree/bindings/arm/*
> Documentation/devicetree/bindings/firmware/*
> Documentation/devicetree/bindings/power/*
> Documentation/devicetree/bindings/soc/*

So, should it go to bindings/power? Or should we get a new
bindings/pmdomain dir?

Konrad