linux-kernel - Re: [RFC PATCH 2/6] sched/fair: Use task_work_queued() on numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xhsmha5ih1ofu.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Date: Tue, 16 Jul 2024 15:00:53 +0200
From: Valentin Schneider <vschneid@...hat.com>
To: Frederic Weisbecker <frederic@...nel.org>, LKML
 <linux-kernel@...r.kernel.org>
Cc: Frederic Weisbecker <frederic@...nel.org>, Peter Zijlstra
 <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Marcelo Tosatti
 <mtosatti@...hat.com>, Vlastimil Babka <vbabka@...e.cz>, Andrew Morton
 <akpm@...ux-foundation.org>, Michal Hocko <mhocko@...nel.org>, Thomas
 Gleixner <tglx@...utronix.de>, Oleg Nesterov <oleg@...hat.com>
Subject: Re: [RFC PATCH 2/6] sched/fair: Use task_work_queued() on numa_work

On 25/06/24 15:52, Frederic Weisbecker wrote:

> @@ -3456,7 +3455,6 @@ void init_numa_balancing(unsigned long clone_flags, struct task_struct *p)
>       p->numa_scan_period		= sysctl_numa_balancing_scan_delay;
>       p->numa_migrate_retry		= 0;

>       /* Protect against double add, see task_tick_numa and task_numa_work */
> -	p->numa_work.next		= &p->numa_work;

You'll want to get rid of the comment there as well.

>       p->numa_faults			= NULL;
>       p->numa_pages_migrated		= 0;
>       p->total_numa_faults		= 0;