linux-kernel - Re: [PATCH 03/17] MIPS: loongson64: rename __node_data to node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2a2bb8b6-09ca-40c3-b6a9-d8fac7dd5208@app.fastmail.com>
Date: Tue, 16 Jul 2024 21:07:59 +0800
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Mike Rapoport" <rppt@...nel.org>, linux-kernel@...r.kernel.org
Cc: "Alexander Gordeev" <agordeev@...ux.ibm.com>,
 "Andreas Larsson" <andreas@...sler.com>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Arnd Bergmann" <arnd@...db.de>, "Borislav Petkov" <bp@...en8.de>,
 "Catalin Marinas" <catalin.marinas@....com>,
 "Christophe Leroy" <christophe.leroy@...roup.eu>,
 "Dan Williams" <dan.j.williams@...el.com>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>,
 "David Hildenbrand" <david@...hat.com>,
 "David S . Miller" <davem@...emloft.net>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Heiko Carstens" <hca@...ux.ibm.com>,
 "Huacai Chen" <chenhuacai@...nel.org>, "Ingo Molnar" <mingo@...hat.com>,
 "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
 "Jonathan Cameron" <jonathan.cameron@...wei.com>,
 "Michael Ellerman" <mpe@...erman.id.au>,
 "Palmer Dabbelt" <palmer@...belt.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>, "Rob Herring" <robh@...nel.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Thomas Gleixner" <tglx@...utronix.de>,
 "Vasily Gorbik" <gor@...ux.ibm.com>, "Will Deacon" <will@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, loongarch@...ts.linux.dev,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
 sparclinux@...r.kernel.org, linux-acpi@...r.kernel.org,
 linux-cxl@...r.kernel.org, nvdimm@...ts.linux.dev,
 devicetree@...r.kernel.org, linux-arch@...r.kernel.org,
 linux-mm@...ck.org, x86@...nel.org
Subject: Re: [PATCH 03/17] MIPS: loongson64: rename __node_data to node_data

在2024年7月16日七月 下午7:13，Mike Rapoport写道：
> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
>
> Make definition of node_data match other architectures.
> This will allow pulling declaration of node_data to the generic mm code in
> the following commit.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

Reviewed-by: Jiaxun Yang <jiaxun.yang@...goat.com>

MIPS should go arch_numa at some point as well.

Thanks
- Jiaxun

> ---
>  arch/mips/include/asm/mach-loongson64/mmzone.h | 4 ++--
>  arch/mips/loongson64/numa.c                    | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/mips/include/asm/mach-loongson64/mmzone.h 
> b/arch/mips/include/asm/mach-loongson64/mmzone.h
> index a3d65d37b8b5..2effd5f8ed62 100644
> --- a/arch/mips/include/asm/mach-loongson64/mmzone.h
> +++ b/arch/mips/include/asm/mach-loongson64/mmzone.h
> @@ -14,9 +14,9 @@
>  #define pa_to_nid(addr)  (((addr) & 0xf00000000000) >> 
> NODE_ADDRSPACE_SHIFT)
>  #define nid_to_addrbase(nid) ((unsigned long)(nid) << 
> NODE_ADDRSPACE_SHIFT)
> 
> -extern struct pglist_data *__node_data[];
> +extern struct pglist_data *node_data[];
> 
> -#define NODE_DATA(n)		(__node_data[n])
> +#define NODE_DATA(n)		(node_data[n])
> 
>  extern void __init prom_init_numa_memory(void);
> 
> diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c
> index 68dafd6d3e25..b50ce28d2741 100644
> --- a/arch/mips/loongson64/numa.c
> +++ b/arch/mips/loongson64/numa.c
> @@ -29,8 +29,8 @@
> 
>  unsigned char __node_distances[MAX_NUMNODES][MAX_NUMNODES];
>  EXPORT_SYMBOL(__node_distances);
> -struct pglist_data *__node_data[MAX_NUMNODES];
> -EXPORT_SYMBOL(__node_data);
> +struct pglist_data *node_data[MAX_NUMNODES];
> +EXPORT_SYMBOL(node_data);
> 
>  cpumask_t __node_cpumask[MAX_NUMNODES];
>  EXPORT_SYMBOL(__node_cpumask);
> @@ -107,7 +107,7 @@ static void __init node_mem_init(unsigned int node)
>  	tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT);
>  	if (tnid != node)
>  		pr_info("NODE_DATA(%d) on node %d\n", node, tnid);
> -	__node_data[node] = nd;
> +	node_data[node] = nd;
>  	NODE_DATA(node)->node_start_pfn = start_pfn;
>  	NODE_DATA(node)->node_spanned_pages = end_pfn - start_pfn;
> 
> @@ -206,5 +206,5 @@ pg_data_t * __init arch_alloc_nodedata(int nid)
> 
>  void arch_refresh_nodedata(int nid, pg_data_t *pgdat)
>  {
> -	__node_data[nid] = pgdat;
> +	node_data[nid] = pgdat;
>  }
> -- 
> 2.43.0

-- 
- Jiaxun