linux-kernel - Re: [PATCH] net: bridge: remove unnecessary cast from netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZpZ2CA5h8hsCu4Id@nanopsycho.orion>
Date: Tue, 16 Jul 2024 15:30:48 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Nikolay Aleksandrov <razor@...ckwall.org>
Cc: Chen Ni <nichen@...as.ac.cn>, roopa@...dia.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	bridge@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bridge: remove unnecessary cast from netdev_priv()

Mon, Jul 15, 2024 at 10:04:26AM CEST, razor@...ckwall.org wrote:
>On 15/07/2024 05:44, Chen Ni wrote:
>> Remove unnecessary cast of void * returned by netdev_priv().
>> 
>> Fixes: 928990631327 ("net: bridge: add notifications for the bridge dev on vlan change")
>> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
>> ---
>>  net/bridge/br_netlink.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
>This is not a fix, the code isn't broken and it doesn't violate
>anything.

Yeah, it's cosmetics, send it to net-next without "Fixes" tag.

>
>Nacked-by: Nikolay Aleksandrov <razor@...ckwall.org>
>
>