linux-kernel - Re: [PATCH] ASoC: SOF: imx8m: Fix DSP control regmap retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f2c9540-943a-46a6-851d-a851ade8ba47@nxp.com>
Date: Tue, 16 Jul 2024 16:36:35 +0300
From: Iuliana Prodan <iuliana.prodan@....com>
To: "Daniel Baluta (OSS)" <daniel.baluta@....nxp.com>,
 linux-sound@...r.kernel.org, broonie@...nel.org
Cc: lgirdwood@...il.com, peter.ujfalusi@...ux.intel.com,
 yung-chuan.liao@...ux.intel.com, ranjani.sridharan@...ux.intel.com,
 daniel.baluta@...il.com, kernel@...gutronix.de, shengjiu.wang@....com,
 laurentiu.mihalcea@....com, imx@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Daniel Baluta <daniel.baluta@....com>
Subject: Re: [PATCH] ASoC: SOF: imx8m: Fix DSP control regmap retrieval

On 7/15/2024 6:16 PM, Daniel Baluta (OSS) wrote:
> From: Daniel Baluta <daniel.baluta@....com>
>
> According to Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> fsl,dsp-ctrl is a phandle to syscon block so we need to use correct
> function to retrieve it.
>
> Currently there is no SOF DSP DTS merged into mainline so there is no
> need to support the old way of retrieving the dsp control node.
>
> Fixes: 9ba23717b292 ("ASoC: SOF: imx8m: Implement DSP start")
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>


Reviewed-by: Iuliana Prodan <iuliana.prodan@....com>


Thanks,
Iulia
> ---
>   sound/soc/sof/imx/imx8m.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c
> index 1c7019c3cbd38..cdd1e79ef9f6a 100644
> --- a/sound/soc/sof/imx/imx8m.c
> +++ b/sound/soc/sof/imx/imx8m.c
> @@ -234,7 +234,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev)
>   	/* set default mailbox offset for FW ready message */
>   	sdev->dsp_box.offset = MBOX_OFFSET;
>   
> -	priv->regmap = syscon_regmap_lookup_by_compatible("fsl,dsp-ctrl");
> +	priv->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,dsp-ctrl");
>   	if (IS_ERR(priv->regmap)) {
>   		dev_err(sdev->dev, "cannot find dsp-ctrl registers");
>   		ret = PTR_ERR(priv->regmap);