linux-kernel - Re: [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240716021543.ghzeiq5yqtov43lk@master>
Date: Tue, 16 Jul 2024 02:15:43 +0000
From: Wei Yang <richard.weiyang@...il.com>
To: Wei Yang <richard.weiyang@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH 1/2] radix tree test suite: include kconfig.h with
 incomplete path

On Fri, Jul 12, 2024 at 07:41:50AM +0000, Wei Yang wrote:
>The include path indicates it is the kconfig.h in tools/include/linux.
>
>Let's use the same format as others for better reading.
>
>Signed-off-by: Wei Yang <richard.weiyang@...il.com>
>CC: "Liam R. Howlett" <Liam.Howlett@...cle.com>
>CC: Matthew Wilcox (Oracle) <willy@...radead.org>
>---
> tools/testing/radix-tree/linux/kernel.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/testing/radix-tree/linux/kernel.h b/tools/testing/radix-tree/linux/kernel.h
>index c0a2bb785b92..fab6f47a9472 100644
>--- a/tools/testing/radix-tree/linux/kernel.h
>+++ b/tools/testing/radix-tree/linux/kernel.h
>@@ -11,7 +11,7 @@
> #include <linux/err.h>
> #include <linux/bitops.h>
> #include <linux/log2.h>
>-#include "../../../include/linux/kconfig.h"
>+#include <linux/kconfig.h>

Liam

I found the original code maybe not correct, but my change log here is not
exact either.

If my understanding is correct. In radix-tree test suite, we want to use the
kconfig.h in local linux/ directory.

But the original format "../../../include/linux/kconfig.h" is the one in
tools/.

My misunderstanding is <linux/kconfig.h> points to tools/. But since we
specify -I. before -I../../include, so it points to the local kconfig.h. This
is what we expect to use. By accident, the code change here seems correct.

If you think my understanding is correct, I would send a v2 with proper
changelog to describe it.

> 
> #define printk printf
> #define pr_err printk
>-- 
>2.34.1

-- 
Wei Yang
Help you, Help me