linux-kernel - Re: [PATCH AUTOSEL 6.9 11/22] drm/amd/display: Reset freesync config before update new state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aac02f31-ba43-458d-b9c2-a68b7869e2a3@amd.com>
Date: Tue, 16 Jul 2024 10:48:03 -0400
From: Hamza Mahfooz <hamza.mahfooz@....com>
To: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Cc: Tom Chung <chiahsuan.chung@....com>, Sun peng Li <sunpeng.li@....com>,
 Jerry Zuo <jerry.zuo@....com>, Daniel Wheeler <daniel.wheeler@....com>,
 Alex Deucher <alexander.deucher@....com>, harry.wentland@....com,
 Rodrigo.Siqueira@....com, christian.koenig@....com, Xinhui.Pan@....com,
 airlied@...il.com, daniel@...ll.ch, alex.hung@....com, roman.li@....com,
 mario.limonciello@....com, joshua@...ggi.es, wayne.lin@....com,
 srinivasan.shanmugam@....com, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH AUTOSEL 6.9 11/22] drm/amd/display: Reset freesync config
 before update new state

Hi Sasha,

On 7/16/24 10:24, Sasha Levin wrote:
> From: Tom Chung <chiahsuan.chung@....com>
> 
> [ Upstream commit 6b8487cdf9fc7bae707519ac5b5daeca18d1e85b ]
> 
> [Why]
> Sometimes the new_crtc_state->vrr_infopacket did not sync up with the
> current state.
> It will affect the update_freesync_state_on_stream() does not update
> the state correctly.
> 
> [How]
> Reset the freesync config before get_freesync_config_for_crtc() to
> make sure we have the correct new_crtc_state for VRR.

Please drop this patch from the stable queue entirely, since it has
already been reverted (as of commit dc1000bf463d ("Revert
"drm/amd/display: Reset freesync config before update new state"")).

> 
> Reviewed-by: Sun peng Li <sunpeng.li@....com>
> Signed-off-by: Jerry Zuo <jerry.zuo@....com>
> Signed-off-by: Tom Chung <chiahsuan.chung@....com>
> Tested-by: Daniel Wheeler <daniel.wheeler@....com>
> Signed-off-by: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index f866a02f4f489..53a55270998cc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -10028,6 +10028,7 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
>   	}
>   
>   	/* Update Freesync settings. */
> +	reset_freesync_config_for_crtc(dm_new_crtc_state);
>   	get_freesync_config_for_crtc(dm_new_crtc_state,
>   				     dm_new_conn_state);
>   
-- 
Hamza