linux-kernel - Re: [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xhshclihkl6d6bbh2f67yuo6qalwekc3qgf4hzvcibri74rh2q@a5qnddnskdm3>
Date: Tue, 16 Jul 2024 11:54:47 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Wei Yang <richard.weiyang@...il.com>
Cc: Matthew Wilcox <willy@...radead.org>, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] radix tree test suite: include kconfig.h with
 incomplete path

* Wei Yang <richard.weiyang@...il.com> [240716 03:56]:
> On Tue, Jul 16, 2024 at 03:31:06AM +0100, Matthew Wilcox wrote:
> >On Tue, Jul 16, 2024 at 02:15:43AM +0000, Wei Yang wrote:
> >> If you think my understanding is correct, I would send a v2 with proper
> >> changelog to describe it.
> >
> >It seems like you're trying to change something that isn't broken.
> 
> Currently we don't find the problem because these two kconfig.h is similar.
> The only difference is the one in tools/ doesn't include "generated/autoconf.h".

We need that include.

> 
> And in related files, like include/linux/xarray.h, includes the correct
> kconfig.h.
> 
> It is not broken, but doesn't mean it is correct, IMO.

This is really annoying because it works today and your change was
correct enough to look right, but it doesn't include the
generated/autoconf.h  - so it's not right.  It took a lot of time to
figure out that it isn't right.

Instead of forward progress, I am spending time debugging make and
compile considerations in test code that works today.  So, maybe it's
not exactly what you want to see in test code, but it doesn't mean it is
worth my time.

Don't change this until there is a reason to make the change.

Thanks,
Liam